Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an egress-policy: warn-only mode #58

Open
varunsh-coder opened this issue Jan 20, 2022 · 1 comment
Open

Implement an egress-policy: warn-only mode #58

varunsh-coder opened this issue Jan 20, 2022 · 1 comment

Comments

@varunsh-coder
Copy link
Member

microsoft/msquic#2310 (comment)

It should not block traffic, but should warn if there are new endpoints.

@wenqiglantz-agi
Copy link

I would like to request this "warn-only" mode as well, in addition to the existing feature of traffic blocking. The use case I ran into is that our github actions workflows contain outbound endpoints referring to AWS region, such as "lambda.us-east-1.amazonaws.com:443". But we don't use the same region for our different AWS accounts, resulting additional outbound endpoints need to be added to the list so traffic doesn't get blocked when running for accounts pointing to a different region than the one defined in the endpoint urls.

I think it's a good idea to let the users/companies decide which approach they are comfortable with. For companies who only deal with a set number of limited regions, adding the respective outbound endpoints for each region is not unreasonable. The problem is that it can be easily missed. Users may not be watching closely enough the region value in the endpoints, ended up traffic getting blocked unintentionally. Warn mode is definitely nice to have, especially for companies who deal with many different regions for different accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants