Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting bug with latest harden runner ouput #88

Closed
jauderho opened this issue Feb 6, 2022 · 2 comments
Closed

Formatting bug with latest harden runner ouput #88

jauderho opened this issue Feb 6, 2022 · 2 comments

Comments

@jauderho
Copy link
Contributor

jauderho commented Feb 6, 2022

When copying the latest code block output from https://app.stepsecurity.io/github/jauderho/dockerfiles/actions/runs/1800983360 , I notice an issue. There seems to be a spurious > in the code block in the same line as allowed-endpoints:.

See below for example,

- name: Harden Runner
  uses: step-security/harden-runner@14dc64f30986eaa2ad2dddcec073f5aab18e5a24 # v1
  with:
    egress-policy: block
    allowed-endpoints: >
      95s5acprodeus1file6.blob.core.windows.net:443
      api.github.com:443
      artifactcache.actions.githubusercontent.com:443
      crates.io:443
      dl-cdn.alpinelinux.org:443
      ghcr.io:443
      github.com:443
      production.cloudflare.docker.com:443
      registry-1.docker.io:443
      sh.rustup.rs:443
      static.crates.io:443
      static.rust-lang.org:443
@varunsh-coder
Copy link
Member

Hi @jauderho thanks for creating the issue. This change was made to address #82. Basically, the earlier formatting was getting changed when one used VS Code. The > sign is a standard method to format YAML. Please let me know if you have feedback. Thanks!

@varunsh-coder
Copy link
Member

@jauderho I will go ahead and close this based on the comments above. Feel free to comment if you have ideas to improve it...Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants