Submission

[stepan]

Ready for review: cc @nesquena @timothy1ee

[timothy1ee]

Stepan, good job! The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

• Good code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
  • Note that by convention, getters in Objective-C don't start with the word "get". The first word of the method is the thing that is returned. For instance, it wouldn't be + (NSArray *) getMovies:(id) object;, it would be + (NSArray *)moviesWithObject:(id)object;
  • Your whitespace is a bit off, take a look at the conventions doc.
• Make sure to put all private methods and properties in the class extension interface instead of the public interface in the header file.
  • If you have an initializer with a variable, by convention, you should make that variable available as a public property (e.g., MovieViewController). I think you have some things exposed there that I wouldn't have made public.

For your information, here is the checklist that I use when I review the homework:

• Movie model. Did you have some way to create it from a dictionary?
• You should have implemented a custom cell. When creating a custom cell, make sure never to use imageView, titleLabel, or subtitleLabel. Those are already used by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.
• You should have loaded all the images asynchronously. One way to do that was to use AFNetworking, installed via CocoaPods.
• You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• If you had a custom cell, you should configure the Auto Layout parameters. We'll review that in class.
• Did you display some loading indicator while you were fetching the movies.
• Did you display an error if you failed while fetching the movies.