Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker compose version #1

Closed
rukai opened this issue Mar 1, 2022 · 6 comments
Closed

docker compose version #1

rukai opened this issue Mar 1, 2022 · 6 comments

Comments

@rukai
Copy link

rukai commented Mar 1, 2022

Is this designed for docker compose version 2 or 3 or both?
Would be good to document this in the readme.

@rbozan
Copy link

rbozan commented Apr 11, 2022

@stephanbuys
Copy link
Owner

@rukai happy to include any compatibility improvements. There's a lot of unit test included, if you find that something is something or doesn't work as expected you are welcome to provide a patch or if you point out the issue I can have a look.

@rbozan
Copy link

rbozan commented Apr 11, 2022

@rukai happy to include any compatibility improvements. There's a lot of unit test included, if you find that something is something or doesn't work as expected you are welcome to provide a patch or if you point out the issue I can have a look.

The only thing I'm wondering if it supports extensions (https://docs.docker.com/compose/compose-file/#extension), which from a quick look doesn't look like it.

@stephanbuys
Copy link
Owner

Yeah, the spec is enormous and I haven't seen those before, but I think it should be simple enough to add. Can you give me a snippet of what you would like to support?

@rbozan
Copy link

rbozan commented Apr 11, 2022

Hi, basically I want to have x-start-shell and x-tab-name visible in the scheme below:

version: "3.9"
x-start-shell: true #<--
services:
  redis:
    image: redis:6.2-alpine

  redis-admin:
    image: erikdubbelboer/phpredisadmin
    depends_on:
      - redis
    environment:
      REDIS_1_HOST: redis
      REDIS_1_NAME: testabc
      REDIS_1_PORT: 6379
    ports:
      - 80:80

    x-tab-name: Redis Admin #<--

@stephanbuys
Copy link
Owner

@rbozan I've implemented support for extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants