changed color to light mode #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't merge this branch without overwriting the existing colour scheme, but I can implement the specified colours into a function which queries an environment variable to conditionally set the CSS. Are the colour values you provided accurate to the ones used in macOS Messages when light mode is enabled (i.e. checked with Digital Color Meter or another utility)? |
|
That would be great! Yes, i used the built-in Digital Color Utility to check these colors. |
|
This has been added in the latest commit, exposing |
|
Oddly, v1.1.0 doesn't seem to do anything. v1.0.2 runs fine when I reverted to it. But no messages at all appear when I type "msg" using 1.1.0… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add light mode. This pull request changes the text color and message colors to match the macOS light mode theme in the native messages app.
My changes override the dark mode colors. If I knew how, I would have added an option to switch between dark or light mode. But at this time I am unable to make such changes. In the future hopefully somebody else could add that.