Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support download of other formats than .stl #2

Open
GoTVm opened this issue Feb 28, 2022 · 1 comment
Open

Support download of other formats than .stl #2

GoTVm opened this issue Feb 28, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@GoTVm
Copy link

GoTVm commented Feb 28, 2022

As the title says, it would be useful if the extension allowed you to also download .scad, .f3d, .3mf and other common formats that people might have uploaded.

@stephancasas
Copy link
Owner

Hello, and thank you for the suggestion.

The original intention was to include all files, but I found that non-STL files did not resolve in the same way that STL files did. In the snippet below, you can actually see where all files are included, but are filtered-out to prevent sending the user to a 404 error:

files = JSON.parse(currentThing).thing.files.filter(
(file) => file.name.split('.').slice(-1)[0].toLowerCase() === 'stl',
);

If I get some time, I'd like to do a little more digging, and enable the downloading of these files, so I'll keep the issue open, and try to figure out something this weekend.

Thanks!

@stephancasas stephancasas added the enhancement New feature or request label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants