Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some elements are in the wrong position #22

Closed
PatrickSproll opened this issue Sep 14, 2020 · 9 comments · Fixed by #23
Closed

some elements are in the wrong position #22

PatrickSproll opened this issue Sep 14, 2020 · 9 comments · Fixed by #23

Comments

@PatrickSproll
Copy link
Contributor

according to specification

  • CONTACT_DETAILS has to be between DEPARTMENT and STREET
  • EMAILS has to be between URL and AUTHENTIFICATION
  • PRODUCT_FEATURES has to be between PRODUCT_ID and PRODUCT_COMPONENTS
@PatrickSproll PatrickSproll mentioned this issue Sep 14, 2020
Merged
@PatrickSproll
Copy link
Contributor Author

Can you please release a new version of NuGet with these changes?

@stephanstapel
Copy link
Owner

consider it done (tonight)

@stephanstapel
Copy link
Owner

done:
https://github.com/stephanstapel/OpenTrans.net/releases/tag/4.0.1
https://www.nuget.org/packages/OpenTrans.net/

@PatrickSproll
Copy link
Contributor Author

Sorry, but I think it's not done
it seems that version 4.0.1 has the same behavior as version 4.0.0

@stephanstapel
Copy link
Owner

oh, sorry to hear that. I'll drop another package tonight. Can you please verify that your changes are present in the master branch?

@stephanstapel stephanstapel reopened this Sep 21, 2020
@PatrickSproll
Copy link
Contributor Author

yes, the changes are in the master branch

@stephanstapel
Copy link
Owner

I have re-packaged the library as 4.0.2 (plus adding some documentation). Can you verify that it is alright now?

@PatrickSproll
Copy link
Contributor Author

Yes, everything is fine now, thanks

@stephanstapel
Copy link
Owner

I am glad that this is solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change the order of some elements according to the specification euphilein/OpenTrans.net
2 participants
@stephanstapel @PatrickSproll