Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minification fails because of es6 features #40

Closed
bnomei opened this issue Mar 13, 2017 · 2 comments
Closed

minification fails because of es6 features #40

bnomei opened this issue Mar 13, 2017 · 2 comments

Comments

@bnomei
Copy link

bnomei commented Mar 13, 2017 •
edited

on line 101 char 12 you use for ... of ... which is es6 or with moz extension. I am prepending your js to mine then doing minification. since i am using jshint, jslint or eslint before minification it fails. I can tell my preprocessor to use es6 on your file only but it would be nice if you include it too. just add to the head of your script...

/*jshint esversion: 6 */
@stephband
Copy link
Owner

I just merged the pull request cc87d44 which gets rid of for...of in favour of while loops. Bumped to 2.0.1. SHould fix your problem.

@bnomei
Copy link
Author

bnomei commented Mar 13, 2017

perfect and so quick. thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephband @bnomei