Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve activate response (v1.1) #9

Open
stephband opened this issue May 10, 2022 · 1 comment
Open

Improve activate response (v1.1) #9

stephband opened this issue May 10, 2022 · 1 comment
Assignees
Labels
feature New feature request

Comments

@stephband
Copy link
Owner

Currently, active slide is updated at scrollend. This makes the pagination highlighting seem a little delayed.

This is because updating active slide involves measuring things in the DOM, and if measurement is done mid-scroll the scroll can become janky. It may be possible to cache some measurements at scrollstart or touchstart or pointerstart or something, and rely on .scrollLeft on the container to infer the 'new' measurements during scroll. Try it for version 1.0.1.

@stephband stephband added the feature New feature request label May 10, 2022
@stephband stephband self-assigned this May 10, 2022
@stephband stephband changed the title Improve activate response (v1.0.1) Improve activate response (v1.1) May 11, 2022
@stephband
Copy link
Owner Author

stephband commented May 15, 2022

This commit 8dcc092 improves activation response via navigation, pagination and gesturing, by updating the active slide right as soon as the slide-show is told to scroll to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

1 participant