Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is syntax for db defaults for FilesystemScanExclude right? #20

Closed
markVnl opened this issue Aug 23, 2021 · 7 comments
Closed

Is syntax for db defaults for FilesystemScanExclude right? #20

markVnl opened this issue Aug 23, 2021 · 7 comments

Comments

@markVnl
Copy link

markVnl commented Aug 23, 2021

after installing (fresh) nethserver-clamscan-1.0.4-1.ns7.sdl.noarch

config show clamscan shows this for FilesystemScanExclude

    FilesystemScanExclude=/boot
/proc
/sys
/usr/share/doc

I wonder if this should not be : FilesystemScanExclude=/boot,/proc,/sys,/usr/share/doc

If so the syntax should be changed here:
https://github.com/stephdl/nethserver-clamscan/blob/ns7/root/etc/e-smith/db/configuration/defaults/clamscan/FilesystemScanExclude

also see:
https://community.nethserver.org/t/clamav-warning-cant-open-file-permission-denied/18836/27

@markVnl markVnl changed the title iIs syntax for db defaults for FilesystemScanExclude right? Is syntax for db defaults for FilesystemScanExclude right? Aug 23, 2021
@markVnl
Copy link
Author

markVnl commented Aug 23, 2021

After further investigation, the browser cache has also to do with it.
If you update while having the cockpit clamscan open the validator fails.

Still think the above is valid.

Also IMVHO the 'sed' in the migration script is risky ...
maybe split on \n (newline) and join again with , is safer (just a thought)

@stephdl
Copy link
Owner

stephdl commented Aug 23, 2021

You are right, I changed the default property for FilesystemScanExclude

I did not understand your second hints, could you explain

@markVnl
Copy link
Author

markVnl commented Aug 23, 2021

the sed is just a longshot because of the corrupted db Marco had...

I also installed version 1.0.3 and did update to 1.0.4 :
the validation of Exuded files failed..
Closing Firefox and login again it worked..

@stephdl
Copy link
Owner

stephdl commented Aug 23, 2021

Closing Firefox and login again it worked..

Yes this is valid for every module, you need to reload the page after an upgrade of a module, we know it. In fact cockpit restart itself after a while of if you disconnect the user.

Nothing I can do, after an upgrade do ctrl+F5 to reload the browser cache

@stephdl
Copy link
Owner

stephdl commented Aug 24, 2021

@markVnl does this PR could close this issue ?

#21

@markVnl
Copy link
Author

markVnl commented Aug 24, 2021

Sure!
(Was only trying to be of some sort of help :) )

@markVnl markVnl closed this as completed Aug 24, 2021
@stephdl
Copy link
Owner

stephdl commented Aug 24, 2021

much appreciated @markVnl because you highlighted a bug, the old default property still got \n separator.

thank again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants