-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure on Windows C++/WinRT #169
Comments
Oh, I found a similar problem on Stack Overflow, could you please fix it? |
Yeah it's looking like someone is bringing in the windows headers without defining NOMINMAX. This is a pretty well known issue with the windows headers.This wouldn't have been a problem if windows followed standard naming conventions for macros. I believe anywhere we bring in windows headers we define NOMINMAX so it's probably another include you are using. Not technically any issue with glaze itself but I think the wrapping the function name like you linked to is probably a good idea since this is such a common issue. You can try defining NOMINMAX at the top off the file that's having problems compiling in the meantime. |
I don't know if defining NOMINMAX will have a chain reaction in Windows programming, I tried fork and modified it in the form of this glaze/include/glaze/frozen/random.hpp Lines 74 to 75 in 28c1a83
Here is the part I forked and modified |
@axojhf, the changes look good to me. If you make a pull request I'll merge it in. |
I tried to use glaze in my WinUI3 project, but I found that the compilation does not pass, while I tested in a normal C++ project that it can compile and run(The C++ version of both projects is set to c++20). I'm new to C++ and I don't know how to deal with this problem
Error Output
The text was updated successfully, but these errors were encountered: