You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally posted by Nukoooo January 4, 2024
I kinda got annoyed by this error so I decided to figure out what happened with it, because the files can be read by Libreoffice, I saw the code checks for '\r' at here
After removing \r from the byte array it can parse the content properly into the struct without any weird behavior. So I'm curious about if checking \r intended or not, if it is, what are the reasons behind this 👀
My code in the project:
The text was updated successfully, but these errors were encountered:
Pardon me for not commenting on this bug. The only reason the carriage return isn't handled was because all the CSV files I was dealing with were company generated without the carriage return. I would like to support this, because windows adds \r\n for most CSV generation.
I'll add support at some point, but if you'd like to make the fix yourself and submit a pull request I would gladly merge it in.
Discussed in #684
Originally posted by Nukoooo January 4, 2024
I kinda got annoyed by this error so I decided to figure out what happened with it, because the files can be read by Libreoffice, I saw the code checks for '\r' at here
glaze/include/glaze/csv/read.hpp
Line 128 in feabaaf
so I wondered if it was because of that so I made a minimum example with the following code (data is from issue #666)
and gave the result:
After removing
\r
from the byte array it can parse the content properly into the struct without any weird behavior. So I'm curious about if checking\r
intended or not, if it is, what are the reasons behind this 👀My code in the project:
The text was updated successfully, but these errors were encountered: