Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loaders is undefined for ExternalModule #11

Closed
rnaud opened this issue Feb 13, 2018 · 3 comments
Closed

loaders is undefined for ExternalModule #11

rnaud opened this issue Feb 13, 2018 · 3 comments

Comments

@rnaud
Copy link

rnaud commented Feb 13, 2018

Hello!
Getting the error TypeError: Cannot read property 'length' of undefined from speed-measure-webpack-plugin/utils.js:50 when I have an externals key in my webpack.config.js

  externals: {
    analytics: 'analytics',
    jquery: 'jQuery'
  }

It seems ExternalModule is wrapping NormalModule inside the issuer key and the top level ExternalModule doesn't have a loaders key.

@stephencookdev
Copy link
Owner

Ah, yeah annoyingly I just spotted this in my local v1 branch

I should be able to push a fix for this tomorrow morning

@stephencookdev
Copy link
Owner

Okay, I've just merged #13

That should fix this for you. Let me know!

@rnaud
Copy link
Author

rnaud commented Feb 14, 2018

This is fixed as well for me in our latest tests, thanks!

@rnaud rnaud closed this as completed Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants