Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack v1, v2 support #8

Closed
stephencookdev opened this issue Feb 13, 2018 · 4 comments
Closed

webpack v1, v2 support #8

stephencookdev opened this issue Feb 13, 2018 · 4 comments
Labels

Comments

@stephencookdev
Copy link
Owner

Currently only webpack v3 has been tested

webpack v1 and v2 should be tested, and if plausible, given support for

@stephencookdev
Copy link
Owner Author

Added in ce354bd

@RinkAttendant6
Copy link

RinkAttendant6 commented Mar 3, 2018

This wasn't added correctly. Now the plugin only indicates compatibility with v1.

npm WARN speed-measure-webpack-plugin@1.0.0 requires a peer of webpack@^1 but none is installed. You must install peer dependencies yourself.

The peerDependency should be ^1 || ^2 || ^3 to indicate compatibility with all three versions, if the plugin is indeed compatible with all of them

@stephencookdev
Copy link
Owner Author

Ah, you're entirely right. I must have accidentally missed the compiler warnings when I merged this change 🙁

I'll raise a fix for this in a mo @RinkAttendant6 - thanks for raising 🙂

But yes, this plugin is compatible with v1/2/3 (not 4 yet)

@stephencookdev stephencookdev reopened this Mar 3, 2018
@stephencookdev
Copy link
Owner Author

Fixed in 1212447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants