fix: add toJSON to ValidationErrors #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
approved these changes
Jun 16, 2023
| constructor(errors: ValidationError[]); | ||
| constructor(message: string); | ||
| constructor(messageOrErrors: ValidationError[] | string) { | ||
| super(typeof messageOrErrors === "string" ? messageOrErrors : errorMessage(messageOrErrors)); | ||
| this.errors = typeof messageOrErrors === "string" ? [] : messageOrErrors; | ||
| // Jest clones without prototype, so explictly setting this as a property rather than a class method | ||
| // https://github.com/jestjs/jest/issues/11958 |
There was a problem hiding this comment.
Ah, I wonder if this is what we missed, i.e. I probably tried defining toJSON as class method. Great comment!
packages/orm/src/rules.ts
Outdated
| constructor(errors: ValidationError[]); | ||
| constructor(message: string); | ||
| constructor(messageOrErrors: ValidationError[] | string) { | ||
| super(typeof messageOrErrors === "string" ? messageOrErrors : errorMessage(messageOrErrors)); | ||
| this.errors = typeof messageOrErrors === "string" ? [] : messageOrErrors; | ||
| // Jest clones without prototype, so explictly setting this as a property rather than a class method | ||
| // https://github.com/jestjs/jest/issues/11958 | ||
| this.toJSON = () => `<ValidationErrors> ${this.message}`; |
There was a problem hiding this comment.
Do you mind making this ValidationErrors: ${this.message}? I just realized/remembered that EntityManager.toJSONs also uses this <...> syntax but not sure why we did that...
There was a problem hiding this comment.
Sure thing! I was also debating returning { message } which would be the default response if we weren't overriding this (sans .entities obviously)
stephenh
pushed a commit
that referenced
this pull request
Jun 16, 2023
## [1.89.2](v1.89.1...v1.89.2) (2023-06-16) ### Bug Fixes * add toJSON to ValidationErrors ([#693](#693)) ([b3c49bd](b3c49bd))
|
🎉 This PR is included in version 1.89.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #692.
This (from my testing, Jest 29.5.0 w/ Circus) should stop issues around circular references by introducing toJSON as a property of ValidationErrors which survives the clone.
I've added in a test to attempt to represent this issue, wasn't sure the best place for it - happy to move/change.