Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use as any on globalThis.Buffer check for bytesFromBase64 #1005

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

jonaskello
Copy link
Collaborator

This is a follow up PR for #1004 which also add as any for the bytesFromBase64 function to make it work fully with strict tsconfig setting. See #967.

@jonaskello
Copy link
Collaborator Author

jonaskello commented Feb 18, 2024

I'm not sure about what happend with the integration/extension-import/* files. They seem to not exist before I ran yarn build:test. So now they are added as new files with this PR but they are not really in scope for this PR. Could it be that they were missing or did I make a mistake somewhere?

@jonaskello
Copy link
Collaborator Author

@stephenh Perhaps I should remove the generated integration/extension-import/* files from this PR as they seem to make the build fail?

@jonaskello
Copy link
Collaborator Author

I went ahead and removed the extra files that was generated by yarn build:test as they are not related to this PR. You can see which ones it was in this commit

@stephenh stephenh merged commit bae741c into stephenh:main Feb 18, 2024
6 checks passed
stephenh pushed a commit that referenced this pull request Feb 18, 2024
## [1.167.8](v1.167.7...v1.167.8) (2024-02-18)

### Bug Fixes

* Use as any on globalThis.Buffer check for bytesFromBase64 ([#1005](#1005)) ([bae741c](bae741c)), closes [#1004](#1004) [#967](#967)
@stephenh
Copy link
Owner

🎉 This PR is included in version 1.167.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stephenh
Copy link
Owner

Ah, I was the passing checks, so merged your PR without seeing the comments about the extra files. :-)

But, yeah, looks like a prior PR must not have ran the right build incantation; I'll do a chore PR to get those added. Thanks for calling it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants