Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing boolean to DeepPartial #287

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

aikoven
Copy link
Collaborator

@aikoven aikoven commented Apr 26, 2021

After making DeepPartial ignore the $type field (#282), the DeepPartial<boolean> produced incorrect result:

type Test = DeepPartial<boolean>;
// {
//    valueOf?: (() => boolean) | undefined;
// } | {
//    valueOf?: (() => boolean) | undefined;
// }

This PR adds boolean to the list of built-in types.

@stephenh
Copy link
Owner

Great!

@stephenh stephenh merged commit ba18380 into stephenh:main Apr 27, 2021
stephenh pushed a commit that referenced this pull request Apr 27, 2021
## [1.79.7](v1.79.6...v1.79.7) (2021-04-27)

### Bug Fixes

* add missing `boolean` to `DeepPartial` ([#287](#287)) ([ba18380](ba18380))
@stephenh
Copy link
Owner

🎉 This PR is included in version 1.79.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aikoven aikoven deleted the fix-deep-partial-booleans branch June 4, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants