fix: Fix integration test codegen script #291
Conversation
The codegen script was importing plugin.ts which expects to read from stdin (which is empty), then calls process.exit. This caused codegen to fail silently.
|
Hey! This seems like a fine change, but out of curiosity what was broken before? AFAICT this is moving where |
Hey sorry my commit description didn't get copied over into the PR. The problem is that plugin.ts tries to do stuff when imported. It calls process.exit and interrupts the codegen. https://github.com/stephenh/ts-proto/blob/main/src/plugin.ts#L59 |
|
Oh shoot! I was running this locally and like "it seems fine" but the wrinkle that "codegen exits so fails silently" was tricking me. :-) Thanks! |
## [1.79.8](v1.79.7...v1.79.8) (2021-05-09) ### Bug Fixes * Fix integration test codegen script ([#291](#291)) ([a51eee5](a51eee5))
|
🎉 This PR is included in version 1.79.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The codegen script was importing plugin.ts which expects to read from stdin (which is empty), then calls process.exit. This caused codegen to fail silently.