feat: Use ternary operator for conditional assignments #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
commented
Nov 16, 2021
| (isTimestamp(field) && (options.useDate === DateOption.DATE || options.useDate === DateOption.STRING)) || | ||
| isValueType(ctx, field) | ||
| ) { | ||
| } else if (readSnippet(`x`).toCodeString() == 'x') { |
There was a problem hiding this comment.
This somehwat unrelated change (first commit) is worth having a 👀. It did not change the code output at all which I guess means it is correct.
There was a problem hiding this comment.
Ah yeah, that's a neat way of doing this.
stephenh
approved these changes
Nov 16, 2021
| (isTimestamp(field) && (options.useDate === DateOption.DATE || options.useDate === DateOption.STRING)) || | ||
| isValueType(ctx, field) | ||
| ) { | ||
| } else if (readSnippet(`x`).toCodeString() == 'x') { |
There was a problem hiding this comment.
Ah yeah, that's a neat way of doing this.
|
Thanks! |
stephenh
pushed a commit
that referenced
this pull request
Nov 16, 2021
# [1.87.0](v1.86.0...v1.87.0) (2021-11-16) ### Features * Use ternary operator for conditional assignments ([#394](#394)) ([d84c084](d84c084))
|
🎉 This PR is included in version 1.87.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the second step initially proposed in #371. In cases where the input value needs to be transformed, we cannot use nullish coalescing or anything new and fancy.
This improves the code output in two ways: