feat: Improve map reading (fromJSON/fromPartial) #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
changed the title
stephenh
pushed a commit
that referenced
this pull request
Nov 24, 2021
# [1.89.0](v1.88.0...v1.89.0) (2021-11-24) ### Features * Improve map reading (fromJSON/fromPartial) ([#410](#410)) ([057d438](057d438))
|
🎉 This PR is included in version 1.89.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the same idea as previous PRs for fromJSON/fromPartial: have exactly one assignment per field.
The explicit typing in reduce is necessary to avoid that TS infers
{}as the output/accumulator type.${fieldType}could be replaced withtypeof message.outputFieldbut then in #402 the output field might become optional but${fieldType}should not change.