feat: add usePrototypeForDefaults option #484
Conversation
chore: update options test
| import { Child_Type, Simple, StateEnum } from './simple'; | ||
|
|
||
| describe('simple', () => { | ||
| it('generates types correctly', () => { |
There was a problem hiding this comment.
Maybe add a test that does a Simple.decode that shows a from-default value like age: 0 has Object.keys().includes("age") === false or what not?
| let createBase = code`createBase${fullName}()`; | ||
| if (options.usePrototypeForDefaults) { | ||
| createBase = code`Object.create(${createBase}) as ${fullName}`; | ||
| } |
There was a problem hiding this comment.
Ah wow, nice how small this change is.
|
@stephenh I added some more appropriate tests. I hope that is what you meant. |
Yep, that's what I meant. Thanks! |
| })).finish()); | ||
|
|
||
| expect(Object.keys(decodedWithZero).includes('age')).toBeFalsy(); | ||
| expect(decodedWithZero.hasOwnProperty('age')).toBeFalsy(); |
There was a problem hiding this comment.
Ah right right, I'd expected this to be truthy, but it's the whole proto3 thing that optionals are not encoded, so presence is broken. But this will work for proto2, which is what the descriptors comein as.
# [1.103.0](v1.102.2...v1.103.0) (2022-01-20) ### Features * add usePrototypeForDefaults option ([#484](#484)) ([8e8c810](8e8c810))
|
🎉 This PR is included in version 1.103.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This adds a feature flag
usePrototypeForDefaultsas discussed in #479I have tested this by building
ts-protowith this change, rebuilding thets-proto-descriptorslib using the rebuiltts-proto, then linking to the newts-proto-descriptorsfromts-protoand re-building all integrations and testing them.