Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bump ts-proto-descriptors. #489

Merged
merged 2 commits into from
Feb 12, 2022
Merged

feat: Bump ts-proto-descriptors. #489

merged 2 commits into from
Feb 12, 2022

Conversation

stephenh
Copy link
Owner

No description provided.

@stephenh stephenh requested a review from Vilsol January 21, 2022 14:40
@Vilsol
Copy link
Collaborator

Vilsol commented Jan 21, 2022

Looks like due to the way we decode meta-typings, we will now need to either find a way to strip out the _unknwonFields field, or just do as any inside the fromPartial

@Vilsol
Copy link
Collaborator

Vilsol commented Jan 21, 2022

It would probably be best if we stripped it from the output, as the generated fromPartial call would strip it anyway. It would also mean that this change would have a persistent output and nothing would change from the previous version.

@stephenh
Copy link
Owner Author

@Vilsol I've not looked super deeply into this yet, but initially I agree that just dropping them from the meta-typings seems like the right thing to do.

@Vilsol
Copy link
Collaborator

Vilsol commented Jan 25, 2022

I think you can merge this now, I don't think we can avoid having JS reordering the fields when it serializes them for meta-typings.

@stephenh stephenh merged commit d454448 into main Feb 12, 2022
@stephenh stephenh deleted the bump-descriptors branch February 12, 2022 01:55
stephenh pushed a commit that referenced this pull request Feb 12, 2022
@semantic-release-bot
chore(release): 1.105.0 [skip ci]
628ec12 
# [1.105.0](v1.104.1...v1.105.0) (2022-02-12)

### Features

* Bump ts-proto-descriptors. ([#489](#489)) ([d454448](d454448)), closes [#493](#493)
@stephenh
Copy link
Owner Author

🎉 This PR is included in version 1.105.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vilsol Vilsol Vilsol approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephenh @Vilsol