fix: pass schema through fromPartial #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
approved these changes
Jan 25, 2022
stephenh
added a commit
that referenced
this pull request
Feb 12, 2022
* feat: Bump ts-proto-descriptors. * fix: pass schema through fromPartial (#493) Co-authored-by: Vilsol <me@vil.so>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to us now using prototypes, the output didn't contain any prototype fields, so we have to pass it through something that decodes the keys, and considering that it will be passed through
fromPartialanyway, then this fits perfectly. We could even remove thefromPartialcall in the output as there should be absolutely no difference and it removes a useless runtime call.