feat: include service and definition types with implementations #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When exporting a service or service definition, also export it as a
type. Previously, you would have to import the value then `typeof` off
of it which is cumbersome. Automate this as it has no runtime overhead
and seems more intuitive.
Before:
```ts
export const TestDefinition = {
name: 'Test',
fullName: 'simple.Test',
methods: {
…
},
} as const;
```
After:
```ts
export type TestDefinition = typeof TestDefinition;
export const TestDefinition = {
name: 'Test',
fullName: 'simple.Test',
methods: {
…
},
} as const;
```
|
Hi @stephenh, Thanks! |
stephenh
approved these changes
May 1, 2022
There was a problem hiding this comment.
Nice! Thanks @niedzielski !
Sorry for the really late review here; have just been busy. Fwiw @fizx yeah I'm perfectly happy with you + other maintainers (cc @boukeversteegh who's been actively lately as well) reviewing and merging PRs, to keep me from being the bottleneck on the project.
stephenh
pushed a commit
that referenced
this pull request
May 1, 2022
# [1.111.0](v1.110.4...v1.111.0) (2022-05-01) ### Features * include service and definition types with implementations ([#552](#552)) ([6b896f4](6b896f4))
|
🎉 This PR is included in version 1.111.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting a service or service definition, also export it as a
type. Previously, you would have to import the value then
typeofoffof it which is cumbersome. Automate this as it has no runtime overhead
and seems more intuitive.
Before:
After: