fix: remove Long import statement when Long was unused #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3846masa
changed the title
stephenh
approved these changes
Jun 20, 2022
| const longInit = options.onlyTypes | ||
| ? code`` | ||
| : code` | ||
| const Long = conditionalOutput( |
There was a problem hiding this comment.
Ah neat! This is smart. @3846masa do you mind adding an in-source comment right before this:
// Instead of exposing `LongImp` directly, let callers think that they are getting the
// `imp(Long)` but really it is that + our long initialization snippet. This means the
// initialization code will only be emitted in files that actually use the Long import.
There was a problem hiding this comment.
Looks good. I'll add it 👍
|
@stephenh |
|
Looks great, thanks @3846masa ! |
stephenh
pushed a commit
that referenced
this pull request
Jun 22, 2022
## [1.115.5](v1.115.4...v1.115.5) (2022-06-22) ### Bug Fixes * remove Long import statement when Long was unused ([#599](#599)) ([58dc10c](58dc10c))
|
🎉 This PR is included in version 1.115.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
haines
added a commit
to cerbos/cerbos-sdk-javascript
that referenced
this pull request
Jun 30, 2022
Signed-off-by: Andrew Haines <haines@cerbos.dev>
haines
added a commit
to cerbos/cerbos-sdk-javascript
that referenced
this pull request
Jun 30, 2022
* chore(deps-dev): Bump ts-proto from 1.115.4 to 1.115.5 Bumps [ts-proto](https://github.com/stephenh/ts-proto) from 1.115.4 to 1.115.5. - [Release notes](https://github.com/stephenh/ts-proto/releases) - [Changelog](https://github.com/stephenh/ts-proto/blob/main/CHANGELOG.md) - [Commits](stephenh/ts-proto@v1.115.4...v1.115.5) --- updated-dependencies: - dependency-name: ts-proto dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Remove ts-proto patch (merged in stephenh/ts-proto#599) Signed-off-by: Andrew Haines <haines@cerbos.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Haines <haines@cerbos.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somethimes (e.g. when outputEncodeMethods=false), Long is not required, but included in generated codes.
This PR ensures that unused Long is not included in generated codes.
Releated: #330