feat: Add use-numeric-enum-json option. #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this option is enabled, the JSON encoder (toJSON) will encode enum values as integer, rather than the string.
|
Related issue: #96 |
|
@stephenh Could you take a look when you have a chance? |
|
Looks good, thanks @kev0960 ! |
stephenh
pushed a commit
that referenced
this pull request
Jul 28, 2022
# [1.121.0](v1.120.0...v1.121.0) (2022-07-28) ### Features * Add use-numeric-enum-json option. ([#625](#625)) ([cd53d8c](cd53d8c))
|
🎉 This PR is included in version 1.121.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this option is enabled, the JSON encoder (toJSON) will encode enum values as integer, rather than the string.
I need this option because I am using proto for the API between rust server and the react based client, and proto on the Rust side expects JSON to have integer values for the enum, rather than the string. It is also faster to compare integer so I think this is an option worthy added.