Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a protobuf file contains a message named
Record
, it causes conflicts with the utility types at the bottom of the file which were using the built-in TSRecord
utility. This obviously causes the file to contain invalid Typescript since we'd expectRecord
to be the utility generic, not the non-generic type generated by this library.To alleviate this issue, I added a test to treat
Record
as a reserved word and fixed the implementation to avoid using it and instead used the mapped types to emulate whatRecord
does. The alternatives I considered seemed to be more trouble than they were worth given that there was only the single usage ofRecord
in the generated output.