Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change channel options to client options in generate grpc/js #704

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

Focadecombate
Copy link
Contributor

@Focadecombate Focadecombate commented Nov 15, 2022

Changes Channel Options type to Client Options and removes 2 not used imports
Fixes #693

@stephenh
Copy link
Owner

Looks great, thanks @Focadecombate !

@stephenh stephenh merged commit c4ac8ac into stephenh:main Nov 15, 2022
stephenh pushed a commit that referenced this pull request Nov 15, 2022
# [1.132.0](v1.131.2...v1.132.0) (2022-11-15)

### Features

* change channel options to client options in generate grpc/js ([#704](#704)) ([c4ac8ac](c4ac8ac))
@stephenh
Copy link
Owner

🎉 This PR is included in version 1.132.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

stephenh added a commit to Focadecombate/ts-proto that referenced this pull request Nov 20, 2022
* main:
  chore(release): 1.132.1 [skip ci]
  fix: use-readonly-types for oneof unions (stephenh#706)
  chore(release): 1.132.0 [skip ci]
  feat: change channel options to client options in generate grpc/js (stephenh#704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc-js generated client constructor missing some allowed options
2 participants