feat: include _unknownFields as a field #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ts-proto-descriptors would need an update that follows for the change to _unknownFields |
stephenh
approved these changes
Mar 26, 2023
| ); | ||
| delete (message.options as any)["_unknownFields"]; | ||
| messageOptions = encodedOptionsToOptions(ctx, ".google.protobuf.MessageOptions", message.options._unknownFields); | ||
| delete message.options._unknownFields; |
There was a problem hiding this comment.
It took me awhile to figure out why this wasn't failing CI....
It looks like our CI process right now doesn't actually type-check until the release step, which is unintentional.
That said, I like this change, so 🤷 I'm going to try and push it through and then follow up with a ts-proto-descriptors bump, as you mentioned in the PR description.
|
🎉 This PR is included in version 1.144.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes _unknownFields a part of messages for easier access
Field left as optional as to not break existing code
Also uses
for inas it is marginally faster thanObject.keysConformant to initializeFieldsAsUndefined: