feat: support "lib: es6" #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks @f0rmat1k ! |
stephenh
pushed a commit
that referenced
this pull request
Jun 13, 2023
# [1.149.0](v1.148.2...v1.149.0) (2023-06-13) ### Features * support lib: es6 ([#850](#850)) ([6280677](6280677))
|
🎉 This PR is included in version 1.149.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es2017 doesn't require array length argument. But 2015 and below needs it https://github.com/microsoft/TypeScript/blob/2a37eb2e471e01e510849f0dc108b3699ab869db/src/lib/es2015.iterable.d.ts#L268
Anyway according documentation zero – is default initializer https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array
So if you have
libparam in tsconfig belowes2017, you've got a problem with typechecking.I just replaced every empty call to
(0). It must work on any es lib configuration.