feat: Upgrade to long 5.0.0. #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
pushed a commit
that referenced
this pull request
Jul 15, 2023
# [1.155.0](v1.154.0...v1.155.0) (2023-07-15) ### Features * Upgrade to long 5.0.0. ([#882](#882)) ([4c1e7a6](4c1e7a6))
|
🎉 This PR is included in version 1.155.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long imports are now:
import Long from "long"whenesModuleInteropis on, andimport Long = require("long")whenesModuleInteropis offThis is probably always how our imports should have worked, but it is only the long v5 upgrade's UMD fallback that triggers a TS error on our old
import * as Long from "long"workaround (when we should have been using import Long = require).https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require