Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support using messages called String/Boolean/Number/Array #934

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix: Support using messages called String/Boolean/Number/Array #934

merged 2 commits into from
Oct 2, 2023

Conversation

Hilzu
Copy link
Contributor

@Hilzu Hilzu commented Oct 2, 2023 •
edited

Fixes #927

  • Extend global-this integration test to cover String, Boolean, Number and Array messages
  • Fix remaining places that caused errors when generating code for these messages

@Hilzu Hilzu changed the title WIP fix: Support using messages called String/Boolean/Number Oct 2, 2023
@Hilzu Hilzu changed the title fix: Support using messages called String/Boolean/Number fix: Support using messages called String/Boolean/Number/Array Oct 2, 2023
@Hilzu Hilzu force-pushed the fix/927 branch 2 times, most recently from 38a4bee to 4aed3d1 Compare October 2, 2023 10:05
@Hilzu Hilzu marked this pull request as ready for review October 2, 2023 10:12
@stephenh
Copy link
Owner

stephenh commented Oct 2, 2023

Looks great, thank you!

@stephenh stephenh merged commit f75159b into stephenh:main Oct 2, 2023
7 checks passed
stephenh pushed a commit that referenced this pull request Oct 2, 2023
@semantic-release-bot
chore(release): 1.159.2 [skip ci]
318e607 
## [1.159.2](v1.159.1...v1.159.2) (2023-10-02)

### Bug Fixes

* Support using messages called String/Boolean/Number/Array ([#934](#934)) ([f75159b](f75159b)), closes [#927](#927)
@stephenh
Copy link
Owner

stephenh commented Oct 2, 2023

🎉 This PR is included in version 1.159.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array message type generates invalid code on account of name collision.
2 participants
@Hilzu @stephenh