feat: generate type namespaces for enums as literals #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request adds code for generating a namespace of type declarations for enums as literals that let you use them like regular enums:
old:
new:
this means a library that was previously using
ts-proto
without theenumsAsLiterals=true
can add it with less breakages.Foo.proto
old generated
Foo.ts
new generated
Foo.ts
I've not looked into adding any tests or anything for this change, but if this feature is something you're interested in, I wouldn't mind adding tests (and making any other changes you request)