Fix breaks in responsive layouts #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using min-width breaks responsive layouts. Here's an example of what the default Twenty twelve theme looks like before the fix on a mobile: https://dl.dropboxusercontent.com/u/2758854/2013-09-30%2019.57.33.png The only downside of this fix is that the help button gets a little squished on mobile. Hiding the undo/redo buttons on mobile with a media query would fix it permanently. Do you want me to send a PR for this?
stephenharris
added a commit
that referenced
this pull request
Oct 12, 2013
Fix breaks in responsive layouts
|
Awesome, thank you! (Apologies its taken so long to get round to reviewing this...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using min-width breaks responsive layouts.
Here's an example of what the default Twenty twelve theme looks like before the fix on a mobile:
https://dl.dropboxusercontent.com/u/2758854/2013-09-30%2019.57.33.png
The only downside of this fix is that the help button gets a little squished on mobile.
Hiding the undo/redo buttons on mobile with a media query would fix it permanently. Do you want me to send a PR for this?