Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice: group_paths and filter_unhandled_paths will both default to True #79

Closed
stephenhillier opened this issue Nov 11, 2023 · 2 comments

Comments

@stephenhillier
Copy link
Owner

stephenhillier commented Nov 11, 2023

The default values for group_paths and filter_unhandled_paths will be changing from False to True. Most users will already want to set these both to True, but when these options were added they defaulted to False to avoid changes to existing behavior. See #78

The changes will be made on or after Nov 17, 2023 (a week from now). A deprecation notice is now part of v0.17.0.

Feedback welcome!

@stephenhillier stephenhillier pinned this issue Nov 11, 2023
@drewp
Copy link

drewp commented Nov 13, 2023

For the lazy who are here thanks to your deprecation text:

Change this: app.add_middleware(PrometheusMiddleware, app_name='foo')

to this: app.add_middleware(PrometheusMiddleware, group_paths=True, filter_unhandled_paths=True, app_name='foo')

@stephenhillier
Copy link
Owner Author

Defaults for group_paths and filter_unhandled_paths changed in v0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants