Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Bar Background #43

Open
salmanseifian opened this issue May 14, 2017 · 2 comments
Open

Bottom Bar Background #43

salmanseifian opened this issue May 14, 2017 · 2 comments

Comments

@salmanseifian
Copy link

we can't change the bottom bar background for each page. I used FullscreenParallaxPage with customize layout, but botttom bar can't change according to color of current page.

@stephentuso
Copy link
Owner

Right now to change the whole background color you need to use the background method as shown here. The ViewPager is above the the bottom bar, so setting the background in the fragment layout won't affect the bottom bar.

It would be a good idea to extend the pager down behind the bottom bar and allow backgrounds to be set in the fragments, although some margins would have to be added to the current layouts and that could also potentially mess up the layouts of anyone currently using the library, so I'd consider that a breaking change. I'd like to consolidate all breaking changes into one update, so that might be available in a week or two.

@stephentuso stephentuso modified the milestones: 1.0, 2.0 May 14, 2017
@salmanseifian
Copy link
Author

Thanks dear Stephen @stephentuso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants