Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leakcanary detects memory leak when using the library #68

Closed
apexkid opened this issue Jun 5, 2019 · 3 comments
Closed

Leakcanary detects memory leak when using the library #68

apexkid opened this issue Jun 5, 2019 · 3 comments
Labels

Comments

@apexkid
Copy link

apexkid commented Jun 5, 2019

I integrated this app in my library and Leakcanary detects a memory leak of linear layout if the app is minimized when welcome screens are open and then resumed back again. It seems the issue is the line:

welcomeScreen = new WelcomeHelper(this, MyWelcomeActivity.class);

We are passing an instance of this to welcome activity but when the base activity lifecycle actions happen, WelcomeHelper still holds the instance to the base activity leading to GC not able to run on it and thus a memory leak.

Please help @stephentuso

@stale
Copy link

stale bot commented Aug 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 5, 2019
@apexkid
Copy link
Author

apexkid commented Aug 11, 2019

Sad.

@stale stale bot removed the stale label Aug 11, 2019
@stale
Copy link

stale bot commented Oct 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 10, 2019
@stale stale bot closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant