New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added draft of useDarkMode #33
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/5dPceGcDMxtc8kxyCrqcTFE3GXZg |
hey @teradaian this looks good, but
Regarding, the changes you suggested!
|
hey @teradaian , please hold for a while, as we are changing the UI .. Thanks |
In the light mode please change the input colors also. its more suitable |
hey @AJOALEX012 @teradaian we have been working on the new UI , and its still in progress, we would like to have your ideas for that! If you wish to add more features in the new UI , say the dark mode feature, PLease pull the Latest NEW-UI branch to contribute |
I'll take a look! |
Hey folks, new UI looks nice! had some questions about what your plan is re: styling, now that you've refactored some things. Were you looking to convert entirely to styled components, convert existing CSS to JSS, or try to keep everything css that can be? I think that for global themes to work as a lm/dm solution, styled comp or at least jss functionality will make life easier in the long run, but ultimately it's not my project and it's a bit of a general overhaul to current design so figured I should check. |
hey @teradaian i understand your point, yes we are looking for a better solution for the long run! So its better to use Global styled components . Please let me know
|
Also @teradaian , i would suggest you to create a new Pull request in which your base will be the NEW-UI Branch. |
Global styled components would be, afaik, quite a bit of a rework as you'ld be directly converting a lot of styling to individual components. That would be, likely, outside of the scope of what I can help with. But could be a cool overall solution for you guys if you'll want to heavily use them moving forward. In answer to your second question, it would need to affect most components in some way, vs using something like MUI's built in theme provider palette function? Which, for now, would be a much less invasive and quicker fix, although less versatile long run perhaps. I'll close this old pull request now, sorry to keep posting on here- just was trying to follow this conversation through so I didn't forget anything. |
Some ideas, obviously the button would ideally be a toggle within settings. I'm setting this to draft so you can look at the structure change ideas.
So far:
Still needs:
Hopefully the idea is helpful even if it's to decide you don't want to do it this way at all!