Added Null State Component in NEW-UI #89

Yash-271120 · 2021-05-25T14:04:55Z

Hey! I added the feature where it shows "No results found for the entered State, Pin code or Date, Please Try Again" in the NEW-UI branch. Let me know if there are any issues.!

vercel · 2021-05-25T14:04:59Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/HTeAGQRFL5GokZCEWRUSYxgrjFuT
✅ Preview: https://cowin-vaccine-git-fork-yash-271120-new-ui-ste-f58a2a.vercel.app

stephin007 · 2021-05-25T14:34:01Z

Its not working as expected @Yash-271120
When i select state, it shows the error text even before i select a district.

Also,

i had requested a seperate Component for this.
What packages did you add? as i see 2 lock files,
Please dont add package lock to your commits, as we have already have yarn.lock

Yash-271120 · 2021-05-25T17:42:04Z

Ok I will update that. I will create a component named NullState which will handle the logic for it!
No other packages where added.
Ok I will take care of not adding package lock.

stephin007 · 2021-05-29T13:30:59Z

@Yash-271120 any updates regarding this buddy?

Yash-271120 · 2021-05-30T05:31:04Z

@stephin007 as I mentioned above I created a new component called NullState which takes care of showing the data if available or error message.
You can check the deployed code here.
Let me know if it works fine!

stephin007 · 2021-05-30T08:26:03Z

@Yash-271120 PEASE RESOLVE THE CONFLICTS so that we can merge your code.

Do this by comparing both the branches, please don't REMOVE anything, just add your changes to the file and resolve them!

vercel · 2021-05-30T13:59:06Z

Someone is attempting to deploy a commit to a Personal Account owned by @stephin007 on Vercel.

@stephin007 first needs to authorize it.

Yash-271120 · 2021-05-31T14:05:02Z

@stephin007 I tried resolving the conflicts. Any further thing giving problem?

stephin007 · 2021-05-31T15:26:29Z

@Yash-271120 did you compare the original changes with the NEW-UI branch? did you delete any existing code from the default Branch, if so this change will break the code.

stephin007 · 2021-05-31T15:31:31Z

Deployment has failed @Yash-271120 , since there are some unused variables

src/components/Home/Home.js

Justinnn07 · 2021-05-31T15:53:42Z

@Yash-271120 i tried working with your repo, firstly it is not installing the modules secondly please remove your package-lock.json file ..

stephin007 · 2021-06-01T05:38:46Z

@Yash-271120 , can you make null state component UI a bit more attractive rather just showing the Text.

Also, @Justinnn07 also please test all the instances if Null state is working or not

Justinnn07 · 2021-06-01T05:39:11Z

@Yash-271120 , can you make null state component UI a bit more attractive rather just showing the Text.

Also, @Justinnn07 also please test all the instances if Null state is working or not

sure!

Justinnn07

LGTM! Just make the ui little attractive! 🔥 @Yash-271120

Yash-271120 · 2021-06-01T07:23:02Z

@Yash-271120 , can you make null state component UI a bit more attractive rather just showing the Text.
@stephin007 sure

Let me know how this looks and also if you have any suggestions!

stephin007 · 2021-06-01T17:24:20Z

@Justinnn07 is this PR good to go?

stephin007 · 2021-06-01T17:37:16Z

@Justinnn07 i guess the latest changes are not yet deployed, ill check again please do review then!

stephin007 · 2021-06-01T17:40:37Z

@Justinnn07 please review the code and demo again, now site is deployed with the latest changes

Justinnn07

Please remove your package-lock.json

src/components/Home/Home.js

Justinnn07 · 2021-06-02T03:47:26Z

@Yash-271120 please pull the latest changes from NEW-UI and do the changes over there(if you see any conflicts in this PR.)

Also please remove your package-lock.json

Thanks ..

stephin007 · 2021-06-02T04:27:10Z

@Yash-271120 please remove package.lock and we will merge your request!

Justinnn07

LGTM! @Yash-271120 💥🚀

stephin007 · 2021-06-02T05:20:47Z

@Justinnn07 wait, deployment has failed
let me re initiate

Justinnn07 · 2021-06-02T05:21:49Z

@Justinnn07 wait, deployment has failed
let me re initiate

I knew thats why I didn't merge! Was commenting about this

stephin007 · 2021-06-02T05:26:32Z

Awesome work @Yash-271120 , Looking forward for your contribution in other issues!

stephin007 · 2021-06-02T06:21:46Z

@Yash-271120 were you committing using 2 accounts 😅
As i see conversation messages from yash-271120 and commits from @Spidey2711 .

WHy is that so?

Yash-271120 · 2021-06-02T10:26:48Z

@Yash-271120 were you committing using 2 accounts 😅
As i see conversation messages from yash-271120 and commits from @Spidey2711 .

WHy is that so?

I also don't know why is that happening. I just have 1 account that's @Yash-271120 . 😕

Yash-271120 · 2021-06-02T10:38:53Z

Awesome work @Yash-271120 , Looking forward for your contribution in other issues!

sure!
also thanks to u guys this was my first PR that got merged 😃

stephin007 · 2021-06-02T11:14:57Z

Congratulations @Yash-271120 , Shubh Aarambh ❤️

stephin007 · 2021-06-02T11:15:59Z

@Yash-271120 were you committing using 2 accounts 😅
As i see conversation messages from yash-271120 and commits from @Spidey2711 .
WHy is that so?

I also don't know why is that happening. I just have 1 account that's @Yash-271120 . 😕

This is most probably due to incomplete git setup in your local machine. Anyways its okay now!

stephin007 · 2021-06-02T11:31:41Z

@Yash-271120 seems like your changes are not responsive , can you fix this as soon as possible!

Yash-271120 · 2021-06-03T14:38:59Z

@Yash-271120 seems like your changes are not responsive , can you fix this as soon as possible!

ok i will look into it

Yash-271120 · 2021-06-03T14:52:01Z

This look good?

Added Null State Component in NEW-UI

532bdcb

vercel bot deployed to Preview May 25, 2021 14:05 View deployment

restyled-io bot mentioned this pull request May 25, 2021

Restyle Added Null State Component in NEW-UI #90

Closed

stephin007 mentioned this pull request May 25, 2021

Added Null State Component #83

Closed

✨ added a seperate component

3638710

vercel bot deployed to Preview May 25, 2021 17:45 View deployment

Merge branch 'NEW-UI' into NEW-UI

4214a3d

vercel bot had a problem deploying to Preview May 31, 2021 15:26 Failure

stephin007 requested a review from Justinnn07 May 31, 2021 15:35

Justinnn07 reviewed May 31, 2021

View reviewed changes

src/components/Home/Home.js Show resolved Hide resolved

Justinnn07 assigned Yash-271120 May 31, 2021

Justinnn07 added the bug Something isn't working label May 31, 2021

did the changes again

503a6f7

vercel bot deployed to Preview June 1, 2021 05:32 View deployment

stephin007 requested a review from Justinnn07 June 1, 2021 05:32

Justinnn07 approved these changes Jun 1, 2021

View reviewed changes

vercel bot deployed to Preview June 1, 2021 17:37 View deployment

Justinnn07 requested changes Jun 1, 2021

View reviewed changes

src/components/Home/Home.js Show resolved Hide resolved

stephin007 added this to Development In progress in Cowin Vaccine Availablity Checker Jun 2, 2021

stephin007 linked an issue Jun 2, 2021 that may be closed by this pull request

Add Null State Component #82

Closed

stephin007 requested a review from Justinnn07 June 2, 2021 04:09

Deleted package-lock.json

6815683

Justinnn07 approved these changes Jun 2, 2021

View reviewed changes

vercel bot deployed to Preview June 2, 2021 05:21 View deployment

Justinnn07 merged commit eb98ee3 into stephin007:NEW-UI Jun 2, 2021

stephin007 mentioned this pull request Jun 2, 2021

Not Found Issue Solved #121

Closed

5 tasks

stephin007 moved this from Development In progress to Development Done in Cowin Vaccine Availablity Checker Jun 2, 2021

stephin007 moved this from Development Done to NEW-UI in Cowin Vaccine Availablity Checker Jun 3, 2021

stephin007 moved this from NEW-UI to Staging (DO NOT MOVE ANY CARD) in Cowin Vaccine Availablity Checker Jun 16, 2021

stephin007 moved this from Staging (DO NOT MOVE ANY CARD) to Production in Cowin Vaccine Availablity Checker Jun 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Null State Component in NEW-UI #89

Added Null State Component in NEW-UI #89

Yash-271120 commented May 25, 2021

vercel bot commented May 25, 2021 •

edited

stephin007 commented May 25, 2021

Yash-271120 commented May 25, 2021 •

edited

stephin007 commented May 29, 2021

Yash-271120 commented May 30, 2021

stephin007 commented May 30, 2021

vercel bot commented May 30, 2021

Yash-271120 commented May 31, 2021

stephin007 commented May 31, 2021

stephin007 commented May 31, 2021

Justinnn07 commented May 31, 2021

stephin007 commented Jun 1, 2021

Justinnn07 commented Jun 1, 2021

Justinnn07 left a comment •

edited

Yash-271120 commented Jun 1, 2021 •

edited

stephin007 commented Jun 1, 2021

stephin007 commented Jun 1, 2021 •

edited

stephin007 commented Jun 1, 2021 •

edited

Justinnn07 left a comment

Justinnn07 commented Jun 2, 2021 •

edited by stephin007

stephin007 commented Jun 2, 2021

Justinnn07 left a comment

stephin007 commented Jun 2, 2021

Justinnn07 commented Jun 2, 2021 •

edited

stephin007 commented Jun 2, 2021

stephin007 commented Jun 2, 2021

Yash-271120 commented Jun 2, 2021 •

edited

Yash-271120 commented Jun 2, 2021

stephin007 commented Jun 2, 2021

stephin007 commented Jun 2, 2021

stephin007 commented Jun 2, 2021

Yash-271120 commented Jun 3, 2021

Yash-271120 commented Jun 3, 2021

Added Null State Component in NEW-UI #89

Added Null State Component in NEW-UI #89

Conversation

Yash-271120 commented May 25, 2021

vercel bot commented May 25, 2021 • edited

stephin007 commented May 25, 2021

Yash-271120 commented May 25, 2021 • edited

stephin007 commented May 29, 2021

Yash-271120 commented May 30, 2021

stephin007 commented May 30, 2021

Do this by comparing both the branches, please don't REMOVE anything, just add your changes to the file and resolve them!

vercel bot commented May 30, 2021

Yash-271120 commented May 31, 2021

stephin007 commented May 31, 2021

stephin007 commented May 31, 2021

Justinnn07 commented May 31, 2021

stephin007 commented Jun 1, 2021

Justinnn07 commented Jun 1, 2021

Justinnn07 left a comment • edited

Choose a reason for hiding this comment

Yash-271120 commented Jun 1, 2021 • edited

stephin007 commented Jun 1, 2021

stephin007 commented Jun 1, 2021 • edited

stephin007 commented Jun 1, 2021 • edited

Justinnn07 left a comment

Choose a reason for hiding this comment

Justinnn07 commented Jun 2, 2021 • edited by stephin007

stephin007 commented Jun 2, 2021

Justinnn07 left a comment

Choose a reason for hiding this comment

stephin007 commented Jun 2, 2021

Justinnn07 commented Jun 2, 2021 • edited

stephin007 commented Jun 2, 2021

stephin007 commented Jun 2, 2021

Yash-271120 commented Jun 2, 2021 • edited

Yash-271120 commented Jun 2, 2021

stephin007 commented Jun 2, 2021

stephin007 commented Jun 2, 2021

stephin007 commented Jun 2, 2021

Yash-271120 commented Jun 3, 2021

Yash-271120 commented Jun 3, 2021

vercel bot commented May 25, 2021 •

edited

Yash-271120 commented May 25, 2021 •

edited

Justinnn07 left a comment •

edited

Yash-271120 commented Jun 1, 2021 •

edited

stephin007 commented Jun 1, 2021 •

edited

stephin007 commented Jun 1, 2021 •

edited

Justinnn07 commented Jun 2, 2021 •

edited by stephin007

Justinnn07 commented Jun 2, 2021 •

edited

Yash-271120 commented Jun 2, 2021 •

edited