Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filtering by the node name #242

Closed
tksm opened this issue Mar 4, 2023 · 1 comment · Fixed by #244
Closed

Support filtering by the node name #242

tksm opened this issue Mar 4, 2023 · 1 comment · Fixed by #244
Assignees
Labels
kind/feature New feature or request

Comments

@tksm
Copy link
Contributor

tksm commented Mar 4, 2023

What would you like to be added:

I would like to add a flag --node that filters pods by the node name. This flag will be helpful when we debug pods on the specific node.

# Print a DaemonSet pod on the specific node
stern --node <NODE_NAME> daemonsets/<DS_NAME>

# Print all pods on the specific node
stern --node <NODE_NAME> --no-follow --max-log-requests 1 .

Why is this needed:

We can select pods on the specific node by --field-selector spec.nodeName=<NODE_NAME> too, but having a dedicated flag allows us to implement a completion for node names.

@tksm tksm added the kind/feature New feature or request label Mar 4, 2023
@superbrothers
Copy link
Member

We can select pods on the specific node by --field-selector spec.nodeName=<NODE_NAME> too, but having a dedicated flag allows us to implement a completion for node names.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants