Fix link style & Add underline option #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not interested in this fix? 😕 |
|
I will chime in and saying I am reading this because I need incoming links as well. |
|
@Fabi755 thanks for your contribution. Sorry it took so long to get around to merging this. |
choku2908
pushed a commit
to choku2908/MessengerKit
that referenced
this pull request
Dec 16, 2021
* Use correct style for link attributes * Add underline style option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link style option for incoming & outgoing messages were not correct. Only the outgoing option was used. I fixed that in this PR.
Additional I added a style option for control the underline setting for links.