Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This issue is to report following of best practices in todo list application #4

Open
steveWDamesJr opened this issue Feb 1, 2022 · 0 comments

Comments

@steveWDamesJr
Copy link
Owner

JavaScript Best Practices

  • Keep all the JavaScript code in JS files, not in the script tag. ✔️
  • Keep your code clean following this advice about:
  • type checks ✔️ 
    
  • naming ✔️ 
    
  • simplicity - Look for ways to make functions smaller: 
    

Long function

  • DRY - Could use function for repetitive Local Storage function
             - Delete repetitive code
    

Repeat code lines p88-106

  • If you use node modules, .lock files should be in the repository to avoid problems with future versions of the
    dependencies. - Delete package-lock.json from .gitignore to release files into repository.

Release package-lock.json
If you use ES6, use object destructuring to get the values from an object. This way you can avoid repeating a lot
of code - used destructuring in import statements ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant