Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add JS / TS / TSX generator functions #289

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix: add JS / TS / TSX generator functions #289

merged 2 commits into from
Sep 15, 2023

Conversation

madlabman
Copy link
Contributor

Treat JavaScript generator expressions as functions declarations.

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add this to the tsx parser as well?
Also, it appears that the tests are not passing. You can run them locally with make test

@madlabman
Copy link
Contributor Author

Looks good! Can you add this to the tsx parser as well? Also, it appears that the tests are not passing. You can run them locally with make test

Updated tsx as well, thank you!

I didn't figure out how to run tests previously, because I had tons of "ShaDa" parsing errors. Now the tests should pass.

@madlabman madlabman changed the title fix: add JS as TS generator functions fix: add JS / TS / TSX generator functions Sep 15, 2023
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@stevearc stevearc merged commit 9bcfbaf into stevearc:master Sep 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants