Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telescope): only reverse results when sorting_strategy = "descending" #307

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

folke
Copy link
Contributor

@folke folke commented Oct 13, 2023

results in telescope are reversed to show them in order as they appear in the document.

However, this doesn't work properly when defaults.sorting_strategy = "ascending".

In that case, the table should not be reversed.

With this PR

image

Without

aerial_picker should be on top

image

@stevearc
Copy link
Owner

LGTM thanks!

@stevearc stevearc merged commit b811243 into stevearc:master Oct 13, 2023
7 checks passed
@folke
Copy link
Contributor Author

folke commented Oct 13, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants