Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snakemake #316

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Add snakemake #316

merged 4 commits into from
Oct 17, 2023

Conversation

daler
Copy link
Contributor

@daler daler commented Oct 16, 2023

This adds some support for Snakemake. Since Snakemake is a superset of Python, this copies the existing Python aerial.scm and just adds the ability to navigate rules via aerial.nvim.

I don't quite follow how to make the expected test cases in test/symbols/, so I copied over the Python one to see how the tests break to see if there are any clues...

@daler
Copy link
Contributor Author

daler commented Oct 16, 2023

Ah, tests not enabled for PRs, it seems. @stevearc, tests/symbols/snakemake_test.json will definitely need to be fixed, I don't know how to create the expected results.

@stevearc
Copy link
Owner

Tests are failing because there is no backend detected for the test file. This is because the filetype is not detected. You'll probably need to add another rule here:

norg = "norg", -- Neovim doesn't have built-in norg filetype detection
usd = "usd", -- Neovim doesn't have built-in USD filetype detection
usda = "usd", -- Neovim doesn't have built-in USD filetype detection

To update the symbols snapshot file, run ./run_tests.sh --update. You'll need to have jq installed and in your PATH.

@daler
Copy link
Contributor Author

daler commented Oct 17, 2023

Thanks for the pointer -- tests passing locally now.

@stevearc
Copy link
Owner

Thanks for the PR!

@stevearc stevearc merged commit c306ffc into stevearc:master Oct 17, 2023
7 checks passed
@daler daler deleted the add-snakemake branch October 20, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants