Added aerial queries for objdump #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Oct 28, 2023
There was a problem hiding this comment.
Interface & function sound fine to me; since the LSP symbol concepts don't really map to this use case it's somewhat arbitrary.
To make the tests pass you'll need to make sure the objdump file gets detected with the correct filetype, and you'll need to add a symbols snapshot file. See this comment for more info #316 (comment)
Added objdump to minimal_init.lua
ColinKennedy
force-pushed
the
add_objdump_queries
branch
from
bead549
to
40498f1
Compare
|
Thank you for the tip. It should be working now! |
stevearc
force-pushed
the
add_objdump_queries
branch
from
12f4c20
to
d960ee6
Compare
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that neovim/neovim#23608 and nvim-treesitter/nvim-treesitter@0179a89 merged, objdump files are recognized in Neovim with tree-sitter support. Adding to aerial.nvim as well.
Since objdump files aren't really code, I wasn't sure what the preferred header would be. So I just chose
"Interface"and"Function". Open to suggestions, there.