feat(telescope): Save position into jumplist before 'edit' action #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toh995
commented
Jan 24, 2024
| @@ -128,6 +128,7 @@ local function aerial_picker(opts) | |||
| default_selection_index = default_selection_index, | |||
| sorter = conf.generic_sorter(opts), | |||
| previewer = conf.qflist_previewer(opts), | |||
| push_cursor_on_edit = true, | |||
There was a problem hiding this comment.
I'm really just copying telescope's built-in picker lsp_document_symbols().
See the PR on the telescope repo here: https://github.com/nvim-telescope/telescope.nvim/pull/1234/files#diff-e706c69d9b98d70266879375b7a75301f9a48fde0fdb99fa85449972df202c16R155
|
LGTM thanks! Test failure unrelated. Looks like a treesitter update :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is DIFFERENT from #305 - this PR touches the telescope extension.
Suppose my cursor is on line 24, and then I open the aerial telescope window.
Then I select a symbol and jump to it.
If I press
Ctrl + o, then I want to jump back to line 24.This PR implements this feature.
Tested locally, and it works well for me!