fix(julia): treesitter queries changed upstream #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st the name is useless with multiple dispatch
|
Just finished updating the tests to match the new name format, this should be good to go! |
|
Also because of the breaking changes upstream, I would also recommend doing a patch release with this pretty quickly after merging |
|
Fantastic, thanks so much for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Julia queries to handle the breaking changes upstream.
This also fixes the symbol names to match what the language server returns. With Julia and it's multiple dispatch system it's very important to have the entire function definition in the symbol name. so we return the entire call expression as the
@nameFixes #361