Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/add-sqlfluff #213

Merged
merged 1 commit into from
Nov 27, 2023
Merged

feat/add-sqlfluff #213

merged 1 commit into from
Nov 27, 2023

Conversation

fbuchlak
Copy link
Contributor

No description provided.

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple Q's

lua/conform/formatters/sqlfluff.lua Show resolved Hide resolved
Comment on lines +14 to +17
"pep8.ini",
"pyproject.toml",
"setup.cfg",
"tox.ini",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look python-specific. Is there a reason to include them as root files for sqlfluff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevearc
Copy link
Owner

Thanks for the explanation!

@stevearc stevearc merged commit e8c8683 into stevearc:master Nov 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants