Fix(black): formatting excluded files results in blank buffer (#249) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Dec 28, 2023
lua/conform/runner.lua
Outdated
Comment on lines
174
to
177
| if new_text:match("^%s*$") and not original_text:match("^%s*$") then | ||
| log.trace("Aborting because a formatter returned empty output") | ||
| return | ||
| end |
There was a problem hiding this comment.
I think this is a fine place for it, but I'd say add the buffer name to the log line and make it a warn instead of a trace
tests/runner_spec.lua
Outdated
| local original_lines = { "line one", "line two" } | ||
| vim.api.nvim_buf_set_lines(bufnr, 0, -1, true, original_lines) | ||
| vim.bo[bufnr].modified = false | ||
| test_util.set_formatter_output({ "" }) |
There was a problem hiding this comment.
I recently made a change the moved this out of test_util. You may need to rework the test a bit.
|
Thanks for the PR! |
|
Thanks! This helped me with the I'll try to figure out why that happens and report it later on, but now I can get back to work. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
This fix checks for blank formatter output in
apply_format. Not sure if this is the best place to apply this fix, but seemed the most obvious place since it'll work the same for both sync and async formats